Repository navigation
fix: bind the MJPEG server to the USE_IP address - #1299
Merged
Merged
Conversation
USE_IP (FBConfiguration.bindingIPAddress) restricts the HTTP server to one address via setInterface:, but the MJPEG screenshots broadcaster never set FBTCPSocket.interface, so it always listened on every interface. Apply the same binding address to the broadcaster. When USE_IP is not set the interface stays nil and behaviour is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
mykola-mokhnach
approved these changes
Oct 16, 2026
KazuCocoa
approved these changes
Oct 16, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
## [16.15.3](v16.15.2...v16.15.3) (2026-10-16) ### Bug Fixes * bind the MJPEG server to the USE_IP address ([#1299](#1299)) ([53573cf](53573cf))
|
🎉 This PR is included in version 16.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE_IP(FBConfiguration.bindingIPAddress) restricts the HTTP server to one address throughsetInterface:, but the MJPEG screenshots broadcaster never setsFBTCPSocket.interface, so it always listens on every interface. WithUSE_IP=127.0.0.1, for example when the host reaches WDA through usbmux port forwarding, port 8100 is loopback-only as expected, but the MJPEG stream on 9100 stays reachable from the device's Wi-Fi network by anyone on the same LAN.This change applies the same binding address to the broadcaster. When
USE_IPis not set,interfacestaysniland the listener is created exactly as before (nw_listener_create_with_port), so the default behaviour does not change.Tested on an iPhone 16 Pro running iOS 26.6.2, with a real-device build of this change (Xcode 16.4,
Scripts/ci/build-real.sh), started withUSE_IP=127.0.0.1. Connections to<device Wi-Fi IP>:9100are refused, and the MJPEG stream still works over usbmux on the device's loopback. Before the change, the same setup accepted connections on<device Wi-Fi IP>:9100.🤖 Generated with Claude Code